Asked for help

.gitignore

@@ -0,0 +1 @@
+*.bak

install.sh

@@ -25,15 +25,13 @@ if [[ ! "$ans" =~ ^[yY][eE]?[sS]?$ ]]; then
 	exit 1; 
 fi
 
-touch /tmp/savesync
-printf "s|RCLONE_PREFIX|%s|\n" "$prefix" >/tmp/savesync
-sed -i -e "/tmp/savesync" "savesync[rungame,endgame](sync).ash"
-sed -i -e "/tmp/savesync" "locksync.ash"
-rm "/tmp/savesync"
 printf "Installing scripts...n"
+sed -i "s|RCLONE_PREFIX|$prefix|" "savesync[rungame,endgame](sync).ash"
+sed -i "s|RCLONE_PREFIX|$prefix|" "locksync.ash"
 cp "savesync[rungame,endgame](sync).ash" /recalbox/share/userscripts/
 mkdir -p /recalbox/share/userscripts/manual
 cp "locksync.ash" /recalbox/share/userscripts/manual/
+
 printf "done\n"
 printf "Cleaning up..."
 cd .. || {

locksync.ash

@@ -5,23 +5,23 @@ export REMOTE_BASE="RCLONE_PREFIX"
 export LOG_FILE="/recalbox/share/system/logs/locksync.log"
 
 log() {
-	# $1 = level
+	# Ensure log directory exists
-	# $2 = message
+	mkdir -p "$(dirname "$LOG_FILE")"
 	printf "[%s] [%s] %s\n" "$(date '+%Y-%m-%d %H:%M:%S')" "$1" "$2" >>"$LOG_FILE"
 }
 
-locks=$(find /recalbox/share/saves -name "*.lock")
+# Use find to pipe directly into the loop to handle spaces in filenames correctly
-if [ -z "$locks" ]; then
+find /recalbox/share/saves -name "*.lock" | while read -r lockfile; do
-	log "INFO" "No game locks found"
+	# 1. Get the game path by removing .lock
-else
+	lgame="${lockfile%.lock}"
-	while read -r lockfile; do
+
-		lgame="$(echo "$lockfile" | sed 's/\.lock//')"
+	# 2. Extract the relative path for the remote
-		rgame="$(echo "$lockfile" | sed 's|/recalbox/share/roms/||' | sed 's/\.lock//')"
+	# This removes '/recalbox/share/saves/' from the start of the path
+	rgame="${lgame#/recalbox/share/saves/}"
+
 	if [ -f "$lgame" ]; then
 		log "INFO" "Game found: $lgame"
-		else
+
-			continue
-		fi
 		if rclone copyto "$lgame" "${REMOTE_BASE}/${rgame}"; then
 			log "INFO" "Game synced: $rgame"
 			rm "$lockfile"
@@ -29,5 +29,7 @@ else
 			log "WARN" "Could not sync game $rgame"
 			log "INFO" "Lockfile $lockfile not removed"
 		fi
-	done <"$locks"
+	else
+		log "DEBUG" "Lock found for non-existent file: $lgame"
 	fi
+done